Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delete methods to services and modules #447

Merged

Conversation

TimoGlastra
Copy link
Contributor

Signed-off-by: Timo Glastra [email protected]

@TimoGlastra TimoGlastra requested a review from a team as a code owner August 31, 2021 08:15
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #447 (074b3ab) into main (55c0fa0) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   85.93%   85.70%   -0.24%     
==========================================
  Files         253      253              
  Lines        5433     5448      +15     
  Branches      804      804              
==========================================
  Hits         4669     4669              
- Misses        764      779      +15     
Impacted Files Coverage Δ
.../core/src/modules/connections/ConnectionsModule.ts 70.37% <0.00%> (-1.79%) ⬇️
.../modules/connections/services/ConnectionService.ts 97.17% <0.00%> (-1.68%) ⬇️
.../core/src/modules/credentials/CredentialsModule.ts 87.34% <0.00%> (-1.12%) ⬇️
.../modules/credentials/services/CredentialService.ts 95.78% <0.00%> (-1.23%) ⬇️
packages/core/src/modules/proofs/ProofsModule.ts 90.00% <0.00%> (-1.53%) ⬇️
...s/core/src/modules/proofs/services/ProofService.ts 87.76% <0.00%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c0fa0...074b3ab. Read the comment docs.

@TimoGlastra TimoGlastra merged commit e7ed602 into openwallet-foundation:main Aug 31, 2021
@TimoGlastra TimoGlastra deleted the feat/add-delete-methods branch August 31, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants