feat(core): add discover features protocol #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
commented
Jul 16, 2021
| @@ -49,5 +49,8 @@ | |||
| "rimraf": "~3.0.2", | |||
| "tslog": "^3.2.0", | |||
| "typescript": "~4.3.0" | |||
| }, | |||
| "resolutions": { | |||
| "@types/node": "^15.14.1" | |||
There was a problem hiding this comment.
@types/node v16 was released recently which causes errors with some the types. I'm not sure if it is an error in the types (the error seems weird), so for now we can stick to types of node 15
Codecov Report
@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 86.42% 86.41% -0.01%
==========================================
Files 234 244 +10
Lines 4803 4918 +115
Branches 750 763 +13
==========================================
+ Hits 4151 4250 +99
- Misses 652 668 +16
Continue to review full report at Codecov.
|
JamesKEbert
approved these changes
Jul 17, 2021
| @@ -34,6 +36,15 @@ class Dispatcher { | |||
|
|
|||
| const outboundMessage = await handler.handle(messageContext) | |||
|
|
|||
| // Emit event that allows to hook into received messages | |||
| this.eventEmitter.emit<AgentMessageProcessedEvent>({ | |||
There was a problem hiding this comment.
Really like this addition
jakubkoci
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add discover features protocol.
Currently working on aries-toolbox integration where this is required for.