Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added their label to the connection record #370

Conversation

JamesKEbert
Copy link
Contributor

Adds theirLabel to the connectionRecord for easy access. Correctly fetches the label from the invitation or connection request depending on whether or not the agent is the invitee or inviter. This is a followup to @blu3beri's PR #369.

Signed-off-by: James Ebert [email protected]

@JamesKEbert JamesKEbert requested a review from a team as a code owner July 8, 2021 19:48
@berendsliedrecht
Copy link
Contributor

Awesome, thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #370 (0b58ef6) into main (a78d203) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   87.85%   87.86%           
=======================================
  Files         224      224           
  Lines        4125     4127    +2     
  Branches      491      491           
=======================================
+ Hits         3624     3626    +2     
  Misses        501      501           
Impacted Files Coverage Δ
...modules/connections/repository/ConnectionRecord.ts 96.72% <100.00%> (+0.05%) ⬆️
.../modules/connections/services/ConnectionService.ts 99.30% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78d203...0b58ef6. Read the comment docs.

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@TimoGlastra TimoGlastra merged commit 353e1d8 into openwallet-foundation:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants