Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: method to retrieve credentials for proof request #329

Merged

Conversation

TheTreek
Copy link
Contributor

Added new object that contains the arrays of potential credentials for proof requests
getRequestedCredentialsForProofRequest returns the new object
Added autoSelectCredentialsForProofRequest to have similar functionality as before
Indy credential info is now stored in RequestedPredicate and RequestedAttribute objects

TheTreek added 5 commits June 16, 2021 12:58
Signed-off-by: Patrick Kenyon <[email protected]>
Signed-off-by: Patrick Kenyon <[email protected]>
Signed-off-by: Patrick Kenyon <[email protected]>
@TheTreek TheTreek requested a review from a team as a code owner June 17, 2021 19:22
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #329 (654d68b) into main (ca6fb13) will increase coverage by 0.07%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   88.28%   88.36%   +0.07%     
==========================================
  Files         220      223       +3     
  Lines        4004     4040      +36     
  Branches      465      447      -18     
==========================================
+ Hits         3535     3570      +35     
- Misses        469      470       +1     
Impacted Files Coverage Δ
src/modules/proofs/services/ProofService.ts 85.53% <84.61%> (+3.42%) ⬆️
src/modules/proofs/ProofsModule.ts 88.31% <100.00%> (+0.31%) ⬆️
src/modules/proofs/models/RequestedAttribute.ts 100.00% <100.00%> (ø)
src/modules/proofs/models/RequestedCredentials.ts 72.00% <100.00%> (-28.00%) ⬇️
src/modules/proofs/models/RequestedPredicate.ts 100.00% <100.00%> (ø)
src/modules/proofs/models/RetrievedCredentials.ts 100.00% <100.00%> (ø)
src/modules/proofs/models/index.ts 100.00% <100.00%> (ø)
src/modules/indy/services/IndyHolderService.ts 89.47% <0.00%> (-5.27%) ⬇️
src/transport/index.ts 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6fb13...654d68b. Read the comment docs.

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! thanks @TheThreek.

I have a few small suggestions

package-lock.json Outdated Show resolved Hide resolved
src/modules/proofs/ProofsModule.ts Outdated Show resolved Hide resolved
src/modules/proofs/services/ProofService.ts Outdated Show resolved Hide resolved
src/storage/fs/index.ts Outdated Show resolved Hide resolved
src/modules/proofs/models/RequestedCredentials.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimoGlastra TimoGlastra requested a review from jakubkoci June 18, 2021 23:20
@TimoGlastra TimoGlastra changed the title Feature/proofList feat: method to retrieve credentials for proof request Jun 20, 2021
Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @TheTreek, thanks for your efforts here!

@TimoGlastra TimoGlastra merged commit 012afa6 into openwallet-foundation:main Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants