-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: method to retrieve credentials for proof request #329
feat: method to retrieve credentials for proof request #329
Conversation
…ices Signed-off-by: Patrick Kenyon <[email protected]>
Signed-off-by: Patrick Kenyon <[email protected]>
Signed-off-by: Patrick Kenyon <[email protected]>
…ialInfo in it Signed-off-by: Patrick Kenyon <[email protected]>
Signed-off-by: Patrick Kenyon <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
==========================================
+ Coverage 88.28% 88.36% +0.07%
==========================================
Files 220 223 +3
Lines 4004 4040 +36
Branches 465 447 -18
==========================================
+ Hits 3535 3570 +35
- Misses 469 470 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! thanks @TheThreek.
I have a few small suggestions
…ructor Signed-off-by: Patrick Kenyon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @TheTreek, thanks for your efforts here!
Added new object that contains the arrays of potential credentials for proof requests
getRequestedCredentialsForProofRequest returns the new object
Added autoSelectCredentialsForProofRequest to have similar functionality as before
Indy credential info is now stored in RequestedPredicate and RequestedAttribute objects