fix: remove dependency on global types #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoGlastra
force-pushed
the
fix/remove-jsonwebkey
branch
from
0523432 to
e8d8e3f
Compare
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 87.99% 87.99%
=======================================
Files 226 226
Lines 4223 4223
Branches 520 520
=======================================
Hits 3716 3716
Misses 507 507
Continue to review full report at Codecov.
|
TimoGlastra
force-pushed
the
fix/remove-jsonwebkey
branch
from
b0203ca to
5c05657
Compare
|
dependant on DefinitelyTyped/DefinitelyTyped#53890 -> which is in turn waiting on microsoft/DefinitelyTyped-tools#281 |
jakubkoci
approved these changes
Jun 18, 2021
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
force-pushed
the
fix/remove-jsonwebkey
branch
from
d41a937 to
53a3089
Compare
Signed-off-by: Timo Glastra <[email protected]>
This reverts commit d0cab71. We should always import the buffer package. Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
force-pushed
the
fix/remove-jsonwebkey
branch
from
f0fc310 to
b0a97f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hadn't restricted the types we could used in the tsconfig, meaning we were using both NodeJS globals and DOM globals.
I've restricted the usage of both. This means some
@ts-ignorefor now, but that will be fixed when #322 is merged.