Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add internal polling inbound transporter #323

Conversation

TimoGlastra
Copy link
Contributor

Temporarily internalize polling inbound transporter to make it easier to get started with the framework.

Once we have full mediator support and the new transport system we should remove it ofc. but now it makes lives simpler just by moving it from tests and exporting it from the framework.

@TimoGlastra TimoGlastra requested a review from a team as a code owner June 15, 2021 21:08
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #323 (f7200e9) into main (ca6fb13) will increase coverage by 0.05%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   88.28%   88.33%   +0.05%     
==========================================
  Files         220      222       +2     
  Lines        4004     4030      +26     
  Branches      465      466       +1     
==========================================
+ Hits         3535     3560      +25     
- Misses        469      470       +1     
Impacted Files Coverage Δ
src/transport/PollingInboundTransporter.ts 95.65% <95.65%> (ø)
src/transport/index.ts 100.00% <100.00%> (ø)
src/utils/sleep.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6fb13...f7200e9. Read the comment docs.

@TimoGlastra TimoGlastra merged commit 6dd273b into openwallet-foundation:main Jun 17, 2021
@TimoGlastra TimoGlastra deleted the feature/polling-inbound-transport branch June 17, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants