-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds support for linked attachments #320
feat: adds support for linked attachments #320
Conversation
Signed-off-by: blu3beri <[email protected]>
Signed-off-by: blu3beri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just some suggestions :)
Signed-off-by: blu3beri <[email protected]>
Signed-off-by: blu3beri <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #320 +/- ##
==========================================
+ Coverage 87.86% 87.99% +0.13%
==========================================
Files 224 226 +2
Lines 4127 4223 +96
Branches 491 520 +29
==========================================
+ Hits 3626 3716 +90
- Misses 501 507 +6
Continue to review full report at Codecov.
|
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
…work-javascript into feature/attachments
Implements 0641.
It allows for attachments outside of the credential to be linked to a credential. This means that it will be way less resource intensive as it does not have to sign the entire attachment, but just the link (a sub 100 char string).
For now a default threshold has been set at 5 megabytes inside the mediator as with bigger images it would just get too cumbersome and as stated in the attachment RFC, messages should remain small. Attachments above 5 megabytes are possible, however they have to be hosted and the link(s) have to be supplied in the linked attachment object.
this will help a lot of mobile agents as after some testing with larger attachments (1mb+) in the Animo react native wallet, it crashed.
Setting of the threshold might be better to do somewhere else, but since the mediator is external it might be not something worth implementing.