Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use both thread id and connection id #299

Conversation

TimoGlastra
Copy link
Contributor

Using only the thread id gives errors when issuing or proving to yourself as there are multiple records for a single thread id. This retrieves records by both thread id an connection id. this also removes the requirement to check if the record has the correct connection id.

@TimoGlastra TimoGlastra requested a review from a team as a code owner June 1, 2021 13:43
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #299 (664dab2) into main (6ec201b) will decrease coverage by 0.06%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   88.07%   88.01%   -0.07%     
==========================================
  Files         218      218              
  Lines        3926     3921       -5     
  Branches      452      451       -1     
==========================================
- Hits         3458     3451       -7     
- Misses        468      470       +2     
Impacted Files Coverage Δ
src/modules/credentials/CredentialsModule.ts 86.66% <0.00%> (ø)
src/modules/proofs/ProofsModule.ts 88.00% <0.00%> (ø)
...modules/credentials/repository/CredentialRecord.ts 93.61% <100.00%> (-4.26%) ⬇️
.../modules/credentials/services/CredentialService.ts 88.17% <100.00%> (+0.31%) ⬆️
src/modules/proofs/repository/ProofRecord.ts 88.57% <100.00%> (-5.72%) ⬇️
src/modules/proofs/services/ProofService.ts 82.11% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec201b...664dab2. Read the comment docs.

@jakubkoci jakubkoci merged commit 3366a55 into openwallet-foundation:main Jun 2, 2021
@TimoGlastra TimoGlastra deleted the fix/connection-id-and-thread branch October 2, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants