fix: convert from buffer now also accepts uint8Array #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jakubkoci we ran into an issue with buffer being transformed to uint8Array over the electron bridge |
Codecov Report
@@ Coverage Diff @@
## main #283 +/- ##
=======================================
Coverage 88.63% 88.63%
=======================================
Files 216 216
Lines 3881 3881
Branches 431 446 +15
=======================================
Hits 3440 3440
Misses 441 441
Continue to review full report at Codecov.
|
|
Failing tests should be fixed by #282 |
Signed-off-by: blu3beri <[email protected]>
berendsliedrecht
force-pushed
the
fix/buffer
branch
from
61686b3 to
a70f290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also decodes from uint8Array now instead of only a Buffer.
Necessary for anything that is not in NodeJs.
Signed-off-by: blu3beri [email protected]