support newer did-communication service type #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
jakubkoci
requested changes
Apr 14, 2021
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
|
@jakubkoci I updated the PR according to your feedback |
Git ignores casing by default. Signed-off-by: Timo Glastra <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #233 +/- ##
==========================================
- Coverage 89.06% 89.06% -0.01%
==========================================
Files 174 178 +4
Lines 3302 3383 +81
Branches 364 389 +25
==========================================
+ Hits 2941 3013 +72
- Misses 358 367 +9
Partials 3 3
Continue to review full report at Codecov.
|
berendsliedrecht
pushed a commit
to berendsliedrecht/credo-ts
that referenced
this pull request
May 11, 2021
…tion#233) Signed-off-by: Timo Glastra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the newer
did-communicationservice type in did docs according to RFC 0076IndyAgent services are still supported and we now send out both. This means it is backwards compatible in both ways (receiving and sending diddocs)