fix: revert to ES2017 to fix function generator issues in react native #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Ebert <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 89.01% 89.01%
=======================================
Files 174 174
Lines 3305 3305
Branches 364 364
=======================================
Hits 2942 2942
Misses 360 360
Partials 3 3 Continue to review full report at Codecov.
|
4 tasks
TimoGlastra
approved these changes
Apr 5, 2021
genaris
pushed a commit
to genaris/credo-ts
that referenced
this pull request
Apr 24, 2021
openwallet-foundation#226) Signed-off-by: James Ebert <[email protected]> Signed-off-by: genaris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes React Native record storage non-iterable async function generator issues due to TS configurations: #225
ES2017 was the highest target specifiable to not have not-iterable errors in React Native.
Signed-off-by: James Ebert [email protected]