fix: implicit invitation to specific service #1592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that our implicit invitation implementation for DID Exchange does not conform exactly with what's written in RFC 0023:
So it assumes that the implicit invitation should go to a specific service that contains a suitable DIDComm communication endpoint (e.g.
did:method:example#invitation
). However, in our implementation we are simply using the did and just selecting the highest priority DIDComm service.Whilst I don't think it is bad for implicit invitations to work the way we are using it, here I'm adding the possibility of directing them to a specific service, so it will use it instead of resolving all DIDComm services the DID Document may have.