fix: create message subscription first #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
genaris
approved these changes
Aug 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #1549 +/- ##
=======================================
Coverage 85.73% 85.73%
=======================================
Files 950 950
Lines 22744 22744
Branches 3978 3978
=======================================
Hits 19500 19500
Misses 3059 3059
Partials 185 185
|
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Nov 15, 2023
Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Martin Auer <[email protected]>
auer-martin
pushed a commit
to auer-martin/aries-framework-javascript
that referenced
this pull request
Dec 4, 2023
Signed-off-by: Timo Glastra <[email protected]> Signed-off-by: Martin Auer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mediation initialization was happening before the message subscription was registered, thus meaning the received messages to provision the mediator wouldn't be processed. This moves it to the start of the initialize method, before mediation initialization