Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(samples): mediator wallet and http transport #1508

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Jul 12, 2023

Adds IndySdkModule to Agent modules in order to allow it to have a default Wallet and Storage implementation (it could be Askar once we solve the performance issue for node <18 and/or drop support for it).

In HttpInboundTransport, It also moves content-type validation to the specific endpoint rather than the whole HTTP server. This is needed to allow using an invitation endpoint.

@genaris genaris requested a review from a team as a code owner July 12, 2023 18:30
@codecov-commenter
Copy link

Codecov Report

Merging #1508 (f2b622e) into main (002be4f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main    #1508    +/-   ##
========================================
  Coverage   85.79%   85.79%            
========================================
  Files         943      943            
  Lines       22588    22588            
  Branches     3685     3915   +230     
========================================
  Hits        19380    19380            
+ Misses       3200     3027   -173     
- Partials        8      181   +173     

see 67 files with indirect coverage changes

@TimoGlastra
Copy link
Contributor

Should we:

  • make the wrappers only support node 18 (they basically already do)
  • update afj to only support 18 (and maybe 20) in 0.5
  • add the patched ref napi to all the wrappers by default

Would solve quite some performance and setup issues.

Node 16 will be EOL in september, we can be ahead of EOL by a few months for once as we have a good reason

@genaris genaris merged commit 04a8058 into openwallet-foundation:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants