Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(w3c): add convenience methods to vc and vp #1477

Merged

Conversation

TimoGlastra
Copy link
Contributor

No description provided.

@TimoGlastra TimoGlastra requested a review from a team as a code owner June 4, 2023 15:04
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2023

Codecov Report

Merging #1477 (d2a7bf2) into main (e0c991f) will increase coverage by 4.98%.
The diff coverage is 17.39%.

@@            Coverage Diff             @@
##             main    #1477      +/-   ##
==========================================
+ Coverage   79.90%   84.88%   +4.98%     
==========================================
  Files         905      943      +38     
  Lines       21912    22578     +666     
  Branches     3811     3911     +100     
==========================================
+ Hits        17509    19166    +1657     
+ Misses       4096     3202     -894     
+ Partials      307      210      -97     
Impacted Files Coverage Δ
...rc/modules/vc/jwt-vc/W3cJwtVerifiableCredential.ts 45.45% <0.00%> (-2.17%) ⬇️
...ntegrity/models/W3cJsonLdVerifiablePresentation.ts 50.00% <18.18%> (-40.00%) ⬇️
...-integrity/models/W3cJsonLdVerifiableCredential.ts 76.19% <20.00%> (-17.93%) ⬇️
.../modules/vc/jwt-vc/W3cJwtVerifiablePresentation.ts 54.54% <20.00%> (-6.17%) ⬇️

... and 155 files with indirect coverage changes

Copy link
Contributor

@karimStekelenburg karimStekelenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy one, LGTM

@TimoGlastra TimoGlastra enabled auto-merge (squash) June 9, 2023 08:25
@TimoGlastra TimoGlastra merged commit 83cbfe3 into openwallet-foundation:main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants