Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(indy-vdr): schema + creddef endorsement #1451

Merged
merged 5 commits into from
May 19, 2023

Conversation

auer-martin
Copy link
Contributor

No description provided.

@auer-martin auer-martin requested a review from a team as a code owner May 10, 2023 12:03
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #1451 (7a27596) into main (9a43afe) will increase coverage by 0.32%.
The diff coverage is 92.75%.

@@            Coverage Diff             @@
##             main    #1451      +/-   ##
==========================================
+ Coverage   85.54%   85.87%   +0.32%     
==========================================
  Files         886      911      +25     
  Lines       21150    21742     +592     
  Branches     3635     3727      +92     
==========================================
+ Hits        18093    18670     +577     
- Misses       2882     2893      +11     
- Partials      175      179       +4     
Impacted Files Coverage Δ
packages/core/src/crypto/keyUtils.ts 85.71% <ø> (+10.71%) ⬆️
...s/core/src/modules/dids/domain/key-type/ed25519.ts 100.00% <ø> (+4.54%) ⬆️
...ds/domain/verificationMethod/VerificationMethod.ts 100.00% <ø> (ø)
packages/askar/src/wallet/AskarWallet.ts 65.71% <50.00%> (+0.31%) ⬆️
.../src/modules/dids/domain/key-type/keyDidMapping.ts 83.33% <66.66%> (-7.58%) ⬇️
packages/anoncreds/src/AnonCredsApi.ts 70.81% <75.00%> (+1.34%) ⬆️
...ore/src/modules/dids/methods/jwk/JwkDidResolver.ts 88.88% <88.88%> (ø)
...ges/core/src/modules/dids/domain/keyDidDocument.ts 98.14% <92.85%> (-1.86%) ⬇️
.../src/modules/dids/methods/jwk/didJwkDidDocument.ts 94.11% <93.33%> (ø)
...indy-vdr/src/anoncreds/IndyVdrAnonCredsRegistry.ts 86.70% <94.44%> (+3.25%) ⬆️
... and 24 more

... and 26 files with indirect coverage changes

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @2mau . Most comments I've left are straightforward to solve. I think main issue (and I'm not sure yet how to solve) is:

This is indy specific code, and we should thus not add it here. Mainly because it means for other methods it's not possible to make a registrar that has an action of wait that does not require changes to the internals of the anoncres packages (the Api), instead of just needing to implement the AnonCredsRegistry interface.

demo/src/Faber.ts Outdated Show resolved Hide resolved
packages/anoncreds/src/AnonCredsApi.ts Outdated Show resolved Hide resolved
packages/anoncreds/src/AnonCredsApi.ts Outdated Show resolved Hide resolved
packages/anoncreds/src/AnonCredsApi.ts Outdated Show resolved Hide resolved
packages/anoncreds/src/AnonCredsApi.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@TimoGlastra TimoGlastra merged commit 25b981b into openwallet-foundation:main May 19, 2023
@auer-martin auer-martin deleted the feat/endorsement branch December 4, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants