-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(indy-vdr): schema + creddef endorsement #1451
feat(indy-vdr): schema + creddef endorsement #1451
Conversation
0f692f3
to
fc85a75
Compare
Signed-off-by: Martin Auer <[email protected]>
fc85a75
to
e3808d4
Compare
…ipt into feat/endorsement
Codecov Report
@@ Coverage Diff @@
## main #1451 +/- ##
==========================================
+ Coverage 85.54% 85.87% +0.32%
==========================================
Files 886 911 +25
Lines 21150 21742 +592
Branches 3635 3727 +92
==========================================
+ Hits 18093 18670 +577
- Misses 2882 2893 +11
- Partials 175 179 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @2mau . Most comments I've left are straightforward to solve. I think main issue (and I'm not sure yet how to solve) is:
This is indy specific code, and we should thus not add it here. Mainly because it means for other methods it's not possible to make a registrar that has an action of wait that does not require changes to the internals of the anoncres packages (the Api), instead of just needing to implement the AnonCredsRegistry interface.
Signed-off-by: Martin Auer <[email protected]>
Signed-off-by: Martin Auer <[email protected]>
Signed-off-by: Martin Auer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
No description provided.