Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reference to indyLedgers in IndyXXXNotConfiguredError #1397

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Mar 21, 2023

Errors in indy-vdr and indy-sdk were still referencing to former AgentConfig's indyLedgers array, which was misleading because now they are set up in module config's networks array.

@genaris genaris requested a review from a team as a code owner March 21, 2023 12:48
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Merging #1397 (957a803) into main (1125e81) will decrease coverage by 4.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
- Coverage   85.34%   80.75%   -4.59%     
==========================================
  Files         788      788              
  Lines       19408    19408              
  Branches     3151     3151              
==========================================
- Hits        16563    15673     -890     
- Misses       2838     3728     +890     
  Partials        7        7              
Impacted Files Coverage Δ
packages/indy-sdk/src/ledger/IndySdkPoolService.ts 95.07% <ø> (ø)
packages/indy-vdr/src/pool/IndyVdrPoolService.ts 84.41% <ø> (ø)

... and 17 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@genaris genaris merged commit d6e2ea2 into openwallet-foundation:main Mar 21, 2023
@genaris genaris deleted the fix/indy-ledgers-config branch March 21, 2023 16:56
TimoGlastra added a commit that referenced this pull request May 16, 2023
Co-authored-by: Karim Stekelenburg <[email protected]>
Co-authored-by: Ariel Gentile <[email protected]>
Co-authored-by: Timo Glastra <[email protected]>
Co-authored-by: Jim Ezesinachi <[email protected]>
Co-authored-by: Ry Jones <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kim Ebert <[email protected]>
Co-authored-by: Grammatopoulos Athanasios Vasileios <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Victor Anene <[email protected]>
Co-authored-by: Jim Ezesinachi <[email protected]>
Co-authored-by: KolbyRKunz <[email protected]>
Co-authored-by: Berend Sliedrecht <[email protected]>
Co-authored-by: Jason C. Leach <[email protected]>
Co-authored-by: Martin Auer <[email protected]>
Co-authored-by: Niall Shaw <[email protected]>
Co-authored-by: Pritam Singh <[email protected]>
Co-authored-by: Mo <[email protected]>
Co-authored-by: NB-MikeRichardson <[email protected]>
Co-authored-by: Amit-Padmani <[email protected]>
Co-authored-by: DaevMithran <[email protected]>
Co-authored-by: Alexander Shenshin <[email protected]>
fix(openid4vc-client): set package to private (#1210)
fix: fix typing issues with typescript 4.9 (#1214)
Fixes #1205
resolver (#1247)
fix: set updateAt on records when updating a record (#1272)
fix(transport)!: added docs moved connection to connectionId (#1222)
fix(indy-vdr): export relevant packages from root (#1291)
fix(askar): generate nonce suitable for anoncreds (#1295)
resolver and registrar for did:indy (#1253)
fix: imports from core (#1303)
fix: thread id improvements (#1311)
fix: loosen base64 validation (#1312)
fix(samples): dummy module response message type (#1321)
fix: seed and private key validation and return type in registrars (#1324)
fix!: don't emit legacy did:sov prefix for new protocols (#1245)
fix(askar): anoncrypt messages unpacking (#1332)
fix: expose indy pool configs and action menu messages (#1333)
fix: create new socket if socket state is 'closing' (#1337)
fix(anoncreds): include prover_did for legacy indy (#1342)
fix(indy-sdk): import from core (#1346)
fix(anoncreds-rs): save revocation registry index (#1351)
fix: isNewSocket logic (#1355)
fix(tenant): Correctly configure storage for multi tenant agents (#1359)
Fixes hyperledger#1353
fix(anoncreds): Buffer not imported from core (#1367)
fix(core): repository event when calling deleteById (#1356)
fix(askar): custom error handling (#1372)
fix: return HTTP 415 if unsupported content type (#1313)
fix: remove named capture groups (#1378)
fix example usage of indy-sdk-react-native package (#1382)
fix: connection id in sessions for new connections (#1383)
fix: did cache key not being set correctly (#1394)
fix: incorrect type for anoncreds registration (#1396)
fix: reference to indyLedgers in IndyXXXNotConfiguredError (#1397)
fix: add reflect-metadata (#1409)
fix: various anoncreds revocation fixes (#1416)
fix: jsonld credential format identifier version (#1412)
fix: remove `deleteOnFinish` and added documentation (#1418)
fix(askar): default key derivation method (#1420)
fix(anoncreds): make revocation status list inline with the spec (#1421)
fix(anoncreds-rs): revocation status list as JSON (#1422)
fix: issuance with unqualified identifiers (#1431)
fix(connections): store imageUrl when using DIDExchange (#1433)
fix(indy-vdr): do not force indy-vdr version (#1434)
fix: small issues with migration and WAL files (#1443)
fix: migration of link secret (#1444)
fix: Emit RoutingCreated event for mediator routing record (#1445)
fix: small updates to cheqd module and demo (#1439)
fix: remove scope check from response (#1450)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants