Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anoncreds): add getCredential(s) methods #1386

Merged

Conversation

TimoGlastra
Copy link
Contributor

@TimoGlastra TimoGlastra commented Mar 18, 2023

Fixes #1263

@TimoGlastra TimoGlastra requested a review from a team as a code owner March 18, 2023 20:30
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Merging #1386 (9c41568) into main (4a6b99c) will increase coverage by 0.41%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1386      +/-   ##
==========================================
+ Coverage   84.83%   85.24%   +0.41%     
==========================================
  Files         786      786              
  Lines       19371    19383      +12     
  Branches     3151     3151              
==========================================
+ Hits        16433    16523      +90     
+ Misses       2931     2853      -78     
  Partials        7        7              
Impacted Files Coverage Δ
packages/anoncreds/src/AnonCredsApi.ts 68.71% <0.00%> (-1.73%) ⬇️
...s/anoncreds/src/services/AnonCredsHolderService.ts 100.00% <ø> (ø)
...sdk/src/anoncreds/services/IndySdkHolderService.ts 8.13% <0.00%> (-0.28%) ⬇️
...ncreds-rs/src/services/AnonCredsRsHolderService.ts 92.05% <100.00%> (+0.21%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TimoGlastra TimoGlastra enabled auto-merge (squash) March 18, 2023 21:13
@TimoGlastra TimoGlastra merged commit 2efc009 into openwallet-foundation:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add getCredential, getCredentials to AnonCredsApi
3 participants