Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anoncreds): add AnonCreds format services #1385

Merged

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Mar 17, 2023

Add Credential and Proof format services according to Aries RFC 0771.

Essentially the same as Legacy Indy counterparts but using the new identifiers, using entropy instead of prover_did for Credential Request and not restricting identifiers to legacy Indy format, so any AnonCreds method can be used with them.

@genaris genaris requested a review from a team as a code owner March 17, 2023 17:27
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Merging #1385 (b9e9aed) into main (c17013c) will decrease coverage by 1.79%.
The diff coverage is 5.50%.

@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
- Coverage   87.20%   85.42%   -1.79%     
==========================================
  Files         780      782       +2     
  Lines       18749    19167     +418     
  Branches     3042     3116      +74     
==========================================
+ Hits        16351    16374      +23     
- Misses       2391     2786     +395     
  Partials        7        7              
Impacted Files Coverage Δ
packages/anoncreds/src/models/exchange.ts 100.00% <ø> (ø)
...oncreds/src/formats/AnonCredsProofFormatService.ts 3.76% <3.76%> (ø)
...ds/src/formats/AnonCredsCredentialFormatService.ts 6.77% <6.77%> (ø)
packages/anoncreds/src/formats/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great work!!!

Would be good if we could add one e2e test using the public api leveraging the anoncreds formats, but that can be added in a follow up pr as well!

@TimoGlastra TimoGlastra merged commit 5f71dc2 into openwallet-foundation:main Mar 18, 2023
@genaris genaris deleted the feat/anoncreds-format-services branch August 17, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants