Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(anoncreds): support credential attribute value and marker #1369

Merged
merged 19 commits into from
Mar 19, 2023

Conversation

Vickysomtee
Copy link
Contributor

The PR implements the support for queries by credential attribute presence and value

work funded by the Government of Ontario

Victor Anene added 2 commits March 6, 2023 20:21
work funded by the Government of Ontario

Signed-off-by: Victor Anene <[email protected]>
Work funded by the Government of Ontario

Signed-off-by: Victor Anene <[email protected]>
@Vickysomtee Vickysomtee requested a review from a team as a code owner March 6, 2023 19:31
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #1369 (a26cd1e) into main (2efc009) will increase coverage by 0.07%.
The diff coverage is 93.02%.

@@            Coverage Diff             @@
##             main    #1369      +/-   ##
==========================================
+ Coverage   85.24%   85.31%   +0.07%     
==========================================
  Files         786      787       +1     
  Lines       19383    19404      +21     
  Branches     3151     3150       -1     
==========================================
+ Hits        16523    16555      +32     
+ Misses       2853     2842      -11     
  Partials        7        7              
Impacted Files Coverage Δ
...noncreds/src/models/AnonCredsRestrictionWrapper.ts 83.33% <83.33%> (ø)
...ncreds-rs/src/services/AnonCredsRsHolderService.ts 92.54% <93.54%> (+0.49%) ⬆️
packages/anoncreds/src/models/index.ts 100.00% <100.00%> (ø)
...ncreds/src/repository/AnonCredsCredentialRecord.ts 100.00% <100.00%> (+80.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Victor Anene added 2 commits March 7, 2023 09:59
Work funded by the Government of Ontario

Signed-off-by: Victor Anene <[email protected]>
Work funded by the Government of Ontario

Signed-off-by: Victor Anene <[email protected]>
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, but we're missing some tags tests

Copy link
Contributor

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clean! I think it would be nice to have at least a few tests to make sure different border cases are covered.

@TimoGlastra
Copy link
Contributor

Pretty clean! I think it would be nice to have at least a few tests to make sure different border cases are covered.

That's what i meant instead of tags lol

work funded by the Government of Ontario

Signed-off-by: Victor Anene <[email protected]>
@Vickysomtee Vickysomtee marked this pull request as draft March 11, 2023 13:19
@Vickysomtee Vickysomtee marked this pull request as ready for review March 17, 2023 11:27
@Vickysomtee Vickysomtee requested a review from TimoGlastra March 17, 2023 11:29
Signed-off-by: Victor Anene <[email protected]>
Victor Anene added 2 commits March 17, 2023 16:14
@TimoGlastra TimoGlastra changed the title feat: add support for queries by credential attribute value and marker feat(anoncreds): support credential attribute value and marker Mar 18, 2023
@TimoGlastra TimoGlastra enabled auto-merge (squash) March 18, 2023 16:02
@TimoGlastra TimoGlastra merged commit 5559996 into openwallet-foundation:main Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnonCreds: support queries by credential attribute presence and value
4 participants