-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(anoncreds): support credential attribute value and marker #1369
feat(anoncreds): support credential attribute value and marker #1369
Conversation
work funded by the Government of Ontario Signed-off-by: Victor Anene <[email protected]>
Work funded by the Government of Ontario Signed-off-by: Victor Anene <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1369 +/- ##
==========================================
+ Coverage 85.24% 85.31% +0.07%
==========================================
Files 786 787 +1
Lines 19383 19404 +21
Branches 3151 3150 -1
==========================================
+ Hits 16523 16555 +32
+ Misses 2853 2842 -11
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Work funded by the Government of Ontario Signed-off-by: Victor Anene <[email protected]>
Work funded by the Government of Ontario Signed-off-by: Victor Anene <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good, but we're missing some tags tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty clean! I think it would be nice to have at least a few tests to make sure different border cases are covered.
That's what i meant instead of tags lol |
work funded by the Government of Ontario Signed-off-by: Victor Anene <[email protected]>
Signed-off-by: Victor Anene <[email protected]>
…-javascript into proof-restriction
Signed-off-by: Victor Anene <[email protected]>
Signed-off-by: Victor Anene <[email protected]>
…-javascript into proof-restriction
Signed-off-by: Victor Anene <[email protected]>
Signed-off-by: Victor Anene <[email protected]>
packages/anoncreds-rs/src/services/__tests__/AnonCredsRsHolderService.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Victor Anene <[email protected]>
Signed-off-by: Victor Anene <[email protected]>
packages/anoncreds-rs/src/services/__tests__/AnonCredsRsHolderService.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
The PR implements the support for queries by credential attribute presence and value
work funded by the Government of Ontario