Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Before updating credential state to Done we should check if the state is CredentialIssued #123

Closed
TimoGlastra opened this issue Oct 29, 2020 · 0 comments · Fixed by #130
Closed

Before updating credential state to Done we should check if the state is CredentialIssued #123

TimoGlastra opened this issue Oct 29, 2020 · 0 comments · Fixed by #130
Assignees
@jakubkoci
Labels
Type: Bug

Comments

@TimoGlastra
Copy link
Contributor

Before updating the state we should check if the state is CredentialIssued. Otherwise we could go directly from OfferSent to Done without actually issuing a credential

Originally posted by @TimoGlastra in #122 (comment)
@TimoGlastra TimoGlastra changed the title Before updating credential state Done we should check if the state is CredentialIssued Before updating credential state to Done we should check if the state is CredentialIssued Oct 29, 2020
@jakubkoci jakubkoci mentioned this issue Oct 31, 2020
Merged
jakubkoci added a commit that referenced this issue Nov 4, 2020
@jakubkoci
feat: Add assertions for credential state transitions (#130)
00d2b1f 
Fixes #123 

* Move mock declaration to one place for all tests
* Add test to the existence of a credential request and request metadata.
* Add assertion for credential state transitions

Signed-off-by: Jakub Koci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakubkoci jakubkoci

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Validate credential record state transitions
2 participants
@jakubkoci @TimoGlastra