-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(anoncreds): add legacy indy credential format #1220
feat(anoncreds): add legacy indy credential format #1220
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Question: should we call it |
Signed-off-by: Timo Glastra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major, just some small points.
packages/anoncreds/src/formats/LegacyIndyCredentialFormatService.ts
Outdated
Show resolved
Hide resolved
packages/anoncreds/src/services/registry/CredentialDefinitionOptions.ts
Outdated
Show resolved
Hide resolved
packages/anoncreds/src/services/registry/__tests__/AnonCredsRegistryService.test.ts
Outdated
Show resolved
Hide resolved
…gistryService.test.ts Co-authored-by: Berend Sliedrecht <[email protected]> Signed-off-by: Timo Glastra <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
- Coverage 87.64% 87.03% -0.62%
==========================================
Files 739 757 +18
Lines 17619 18068 +449
Branches 2992 3067 +75
==========================================
+ Hits 15443 15726 +283
- Misses 2169 2335 +166
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ce.ts Co-authored-by: Berend Sliedrecht <[email protected]> Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Resolved your feedback @blu3beri |
I think legacy is fine. We are going to name it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment about creating an issue on anoncreds-rs. Otherwise it looks good to me.
can't find the comment 🙃 |
|
Adds a
LegacyIndyCredentialFormat
class to the AnonCreds package that can handle the current indy format as described in RFC 0592. This doesn't support the new ledger agnostic anoncreds yet, but it does implement the old format with the new APIs we have.I've written some initial tests using this service and the new anoncreds apis implemented using the indy-sdk. I'll add more in follow up prs when the api and proof format are added.
Partially fixes #1130, but the proof format is still todo. This will actually be a lot more work as we still need to make the proof interfaces dynamic and allow for dynamic registration of proof protocols