Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: rename Handler to MessageHandler #1161

Conversation

TimoGlastra
Copy link
Contributor

Rename Handler to MessageHandler based on feedback from PR #1158

BREAKING CHANGE: Handler has been renamed to MessageHandler to be more descriptive, along with related types and methods. This means:

  • Handler is now MessageHandler
  • HandlerInboundMessage is now MessageHandlerInboundMessage
  • Dispatcher.registerHandler is now Dispatcher.registerMessageHandlers

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Merging #1161 (9502072) into main (0e89e6c) will not change coverage.
The diff coverage is 96.99%.

@@           Coverage Diff           @@
##             main    #1161   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files         706      706           
  Lines       16503    16503           
  Branches     2678     2678           
=======================================
  Hits        14651    14651           
  Misses       1845     1845           
  Partials        7        7           
Impacted Files Coverage Δ
packages/core/src/modules/proofs/ProofService.ts 68.96% <ø> (ø)
.../modules/connections/handlers/AckMessageHandler.ts 71.42% <50.00%> (ø)
...ctions/handlers/TrustPingResponseMessageHandler.ts 71.42% <50.00%> (ø)
...cation/handlers/V1RevocationNotificationHandler.ts 71.42% <50.00%> (ø)
...cation/handlers/V2RevocationNotificationHandler.ts 71.42% <50.00%> (ø)
...ol/v1/handlers/V1CredentialProblemReportHandler.ts 71.42% <50.00%> (ø)
...ol/v2/handlers/V2CredentialProblemReportHandler.ts 71.42% <50.00%> (ø)
...c/modules/routing/handlers/MediationDenyHandler.ts 62.50% <50.00%> (ø)
packages/action-menu/src/ActionMenuApi.ts 97.82% <100.00%> (ø)
...enu/src/handlers/ActionMenuProblemReportHandler.ts 100.00% <100.00%> (ø)
... and 71 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TimoGlastra TimoGlastra merged commit 5e48696 into openwallet-foundation:main Dec 16, 2022
@TimoGlastra TimoGlastra deleted the feat/rename=handler-to-message-handler branch December 16, 2022 07:45
amanji pushed a commit to petridishdev/aries-framework-javascript that referenced this pull request Dec 19, 2022
Signed-off-by: Timo Glastra <[email protected]>

BREAKING CHANGE: Handler has been renamed to MessageHandler to be more descriptive, along with related types and methods. This means:

Handler is now MessageHandler
HandlerInboundMessage is now MessageHandlerInboundMessage
Dispatcher.registerHandler is now Dispatcher.registerMessageHandlers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants