fix: use custom document loader in jsonld.frame #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoGlastra
approved these changes
Nov 24, 2022
Testing the boundaries of git! 😛 |
|
Haha, it's what happens if you let vscode create a branch based on an issue 🤣 |
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
karimStekelenburg
force-pushed
the
karimStekelenburg/issueW3cCredentialService-Custom-Document-Loader-does-not-work-when-no-Internet-->-e2e-Tests-Fail
branch
from
955aefb to
2dfe0ae
Compare
berendsliedrecht
approved these changes
Dec 5, 2022
| @@ -51,6 +51,7 @@ export const BBS_V1 = { | |||
| '@protected': true, | |||
| id: '@id', | |||
| type: '@type', | |||
|
|
|||
Signed-off-by: Karim Stekelenburg <[email protected]>
|
@blu3beri is it OK to merge? (I've seen you disabled auto-merge but don't know if it's for an specific reason) |
I think @karimStekelenburg wants to add something to an error message still. I will merge it when he adds it :). |
|
@karimStekelenburg is this ready? |
…Custom-Document-Loader-does-not-work-when-no-Internet-->-e2e-Tests-Fail
Codecov Report
@@ Coverage Diff @@
## main #1119 +/- ##
=======================================
Coverage 88.32% 88.32%
=======================================
Files 706 706
Lines 16431 16431
Branches 2664 2664
=======================================
Hits 14513 14513
Misses 1911 1911
Partials 7 7 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a custom document loader for tests that use local files instead of downloading them from the web. Inside this custom document loader, we're calling
jsonld.frame(), but didn't pass the custom document loader. As a result, documents were being fetched from the web during tests, which made the tests fail when there is no internet connection.This minor fix passes the custom document loader to the
jsonld.frame()function and makes sure only local files are used.Fixes #1111
Signed-off-by: Karim Stekelenburg [email protected]