fix(connections): do not log AgentContext object #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1085 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 701 701
Lines 16110 16110
Branches 2597 2597
=======================================
Hits 14232 14232
Misses 1871 1871
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
If this fixes the issue it is quite useful imo :). |
berendsliedrecht
approved these changes
Nov 5, 2022
NB-MikeRichardson
added a commit
to NB-MikeRichardson/aries-framework-javascript
that referenced
this pull request
Nov 8, 2022
fix(connections): do not log AgentContext object (openwallet-foundation#1085)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In last Aries Framework JS call @niall-shaw reported performance issues when accepting multi-use invitations.
I've experienced the same issue after migrating to 0.3.0-alpha.x and it turns out that it was happening because some methods in
DidExchangeProtocolwere logging the whole messageContext object, which now includes agentContext and blocks the console for several seconds. This can be avoided by either logging in INFO mode or customizing the logger being in use to only output a certain depth level of objects.This PR makes a quick-fix of this issue by logging only messageContext.message, to be consistent with other methods from
ConnectionService. Not sure if it's really useful though, but that's another subject to discuss 😄 .