Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getRequestedCredentialsForProofRequest #1028

Conversation

NB-MikeRichardson
Copy link
Contributor

The method getRequestedCredentialsForProofRequest was present in the API before the PPV2 code was merged but somehow got lost.

It has been restored in this PR

Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
@NB-MikeRichardson NB-MikeRichardson requested a review from a team as a code owner September 15, 2022 06:38
Signed-off-by: Mike Richardson <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #1028 (6ccef84) into 0.3.0-pre (82a17a3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           0.3.0-pre    #1028   +/-   ##
==========================================
  Coverage      88.23%   88.23%           
==========================================
  Files            637      637           
  Lines          15092    15096    +4     
  Branches        2542     2542           
==========================================
+ Hits           13316    13320    +4     
  Misses          1678     1678           
  Partials          98       98           
Impacted Files Coverage Δ
packages/core/src/modules/proofs/ProofsApi.ts 85.39% <100.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this flow?

packages/core/src/modules/proofs/ProofsApi.ts Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
@NB-MikeRichardson
Copy link
Contributor Author

Comments resolved, a new e2e test added, yarn.lock corrected.

Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
@TimoGlastra TimoGlastra merged commit 26bb9c9 into openwallet-foundation:0.3.0-pre Sep 22, 2022
@NB-MikeRichardson NB-MikeRichardson deleted the feat/request-credentials branch September 28, 2022 08:25
genaris pushed a commit to 2060-io/aries-framework-javascript that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants