feat: indy revocation (prover & verifier) (#592)

* Added recepientRevocation for createProof Signed-off-by: Patrick Kenyon <[email protected]> * Initial revocation functions for getRequestedCredentialsForProofRequest Signed-off-by: Patrick Kenyon <[email protected]> * Added option to check for revocation status in getRequestedCredentials Signed-off-by: Patrick Kenyon <[email protected]> * sorted transports Signed-off-by: Adam Burdett <[email protected]> * broken message sender tests Signed-off-by: Adam Burdett <[email protected]> * structure fix Signed-off-by: Adam Burdett <[email protected]> * lint import ordering Signed-off-by: Adam Burdett <[email protected]> * if(0) does not work. Signed-off-by: Adam Burdett <[email protected]> * utf-8 decode ws event.data Signed-off-by: Adam Burdett <[email protected]> * indy wallet friendly bits Signed-off-by: Adam Burdett <[email protected]> * correct protocal type Signed-off-by: Adam Burdett <[email protected]> * check invite during init Signed-off-by: Adam Burdett <[email protected]> * id check Signed-off-by: Adam Burdett <[email protected]> * keep sockets with mediators open Signed-off-by: Adam Burdett <[email protected]> * recursive backoff Signed-off-by: Adam Burdett <[email protected]> * timeout Signed-off-by: Adam Burdett <[email protected]> * timeout time Signed-off-by: Adam Burdett <[email protected]> * logger Signed-off-by: Adam Burdett <[email protected]> * propper recursive backoff Signed-off-by: Adam Burdett <[email protected]> * multiple socket timeout support Signed-off-by: Adam Burdett <[email protected]> * Code cleanup Signed-off-by: Patrick Kenyon <[email protected]> * Fix tests and types Signed-off-by: Patrick Kenyon <[email protected]> * Formatting and type fixes Signed-off-by: Patrick Kenyon <[email protected]> * revocation fixes Signed-off-by: Patrick Kenyon <[email protected]> * ran prettier Signed-off-by: Patrick Kenyon <[email protected]> * chore: add ts ignore until types are updated Signed-off-by: James Ebert <[email protected]> * feat: updated tails download to utilize axios and added inline docs Signed-off-by: James Ebert <[email protected]> * chore: fixed formatting Signed-off-by: James Ebert <[email protected]> * chore: removed husky Signed-off-by: James Ebert <[email protected]> * fix: add back husky pre-push Signed-off-by: James Ebert <[email protected]> * chore: formatting Signed-off-by: James Ebert <[email protected]> * fix: fixed error imports Signed-off-by: James Ebert <[email protected]> * chore: resolve dependency loop issues Signed-off-by: James Ebert <[email protected]> * chore: formatting Signed-off-by: James Ebert <[email protected]> * feature: revocation ledger methods & proof get requested credentials revoked status Signed-off-by: James Ebert <[email protected]> * feature: added revocation state creation Signed-off-by: James Ebert <[email protected]> * fix: small tweaks and fixes for revocation Signed-off-by: James Ebert <[email protected]> * feature: takes into account referent revocation intervals Signed-off-by: James Ebert <[email protected]> * chore: cleanup & prettier Signed-off-by: James Ebert <[email protected]> * fix: fixed createrevocationstate types & initial rev reg def caching Signed-off-by: James Ebert <[email protected]> * chore: formatting Signed-off-by: James Ebert <[email protected]> * fix: fixed proofservice test mock Signed-off-by: James Ebert <[email protected]> * chore: minor cleanup Signed-off-by: James Ebert <[email protected]> * chore: rename indyutilitiesservice Signed-off-by: James Ebert <[email protected]> * chore: troubleshooting revocation, added ledger methods for verifying proof of non revocation Signed-off-by: James Ebert <[email protected]> * chore: cleanup & credential storage w/revocation Signed-off-by: James Ebert <[email protected]> * feat: add download to file method to file system Signed-off-by: Timo Glastra <[email protected]> * refactor: use rnfs for react native Signed-off-by: Timo Glastra <[email protected]> * chore: cleanup & log adjustments Signed-off-by: James Ebert <[email protected]> * chore: formatting Signed-off-by: James Ebert <[email protected]> * feat: verify proofs containing proof of non_revocation Signed-off-by: James Ebert <[email protected]> * chore: formatting Signed-off-by: James Ebert <[email protected]> * chore: update indy-sdk-react-native & indy-sdk types Signed-off-by: James Ebert <[email protected]> * chore: adjusts names to be consistent & removing abbreviations Signed-off-by: James Ebert <[email protected]> * chore: updated indy-sdk types to fix proof identifier types Signed-off-by: James Ebert <[email protected]> * fix: indyverifierservice prototype pollution Signed-off-by: James Ebert <[email protected]> Co-authored-by: Patrick Kenyon <[email protected]> Co-authored-by: Adam Burdett <[email protected]> Co-authored-by: Timo Glastra <[email protected]>
openwallet-foundation · Feb 9, 2022 · fb19ff5 · fb19ff5
1 parent 0d478a7
commit fb19ff5
Show file tree

Hide file tree

Showing 22 changed files with 797 additions and 118 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -26,7 +26,7 @@
     "@multiformats/base-x": "^4.0.1",
     "@stablelib/ed25519": "^1.0.2",
     "@stablelib/sha256": "^1.0.1",
-    "@types/indy-sdk": "^1.16.8",
+    "@types/indy-sdk": "^1.16.12",
     "@types/node-fetch": "^2.5.10",
     "@types/ws": "^7.4.4",
     "abort-controller": "^3.0.0",

diff --git a/packages/core/src/modules/credentials/services/CredentialService.ts b/packages/core/src/modules/credentials/services/CredentialService.ts
@@ -648,11 +648,21 @@ export class CredentialService {
 
     const credentialDefinition = await this.ledgerService.getCredentialDefinition(indyCredential.cred_def_id)
 
+    //Fetch Revocation Registry Definition if the issued credential has an associated revocation registry id
+    let revocationRegistryDefinition
+    if (indyCredential.rev_reg_id) {
+      const revocationRegistryDefinitionData = await this.ledgerService.getRevocationRegistryDefinition(
+        indyCredential.rev_reg_id
+      )
+      revocationRegistryDefinition = revocationRegistryDefinitionData.revocationRegistryDefinition
+    }
+
     const credentialId = await this.indyHolderService.storeCredential({
       credentialId: uuid(),
       credentialRequestMetadata,
       credential: indyCredential,
       credentialDefinition,
+      revocationRegistryDefinition,
     })
     credentialRecord.credentialId = credentialId
     credentialRecord.credentialMessage = issueCredentialMessage

diff --git a/packages/core/src/modules/indy/services/IndyHolderService.ts b/packages/core/src/modules/indy/services/IndyHolderService.ts
@@ -1,41 +1,78 @@
+import type { Logger } from '../../../logger'
+import type { RequestedCredentials } from '../../proofs'
 import type * as Indy from 'indy-sdk'
 
 import { Lifecycle, scoped } from 'tsyringe'
 
 import { AgentConfig } from '../../../agent/AgentConfig'
-import { IndySdkError } from '../../../error'
+import { IndySdkError } from '../../../error/IndySdkError'
 import { isIndyError } from '../../../utils/indyError'
 import { IndyWallet } from '../../../wallet/IndyWallet'
 
+import { IndyRevocationService } from './IndyRevocationService'
+
 @scoped(Lifecycle.ContainerScoped)
 export class IndyHolderService {
   private indy: typeof Indy
+  private logger: Logger
   private wallet: IndyWallet
+  private indyRevocationService: IndyRevocationService
 
-  public constructor(agentConfig: AgentConfig, wallet: IndyWallet) {
+  public constructor(agentConfig: AgentConfig, indyRevocationService: IndyRevocationService, wallet: IndyWallet) {
     this.indy = agentConfig.agentDependencies.indy
     this.wallet = wallet
+    this.indyRevocationService = indyRevocationService
+    this.logger = agentConfig.logger
   }
 
+  /**
+   * Creates an Indy Proof in response to a proof request. Will create revocation state if the proof request requests proof of non-revocation
+   *
+   * @param proofRequest a Indy proof request
+   * @param requestedCredentials the requested credentials to use for the proof creation
+   * @param schemas schemas to use in proof creation
+   * @param credentialDefinitions credential definitions to use in proof creation
+   * @throws {Error} if there is an error during proof generation or revocation state generation
+   * @returns a promise of Indy Proof
+   *
+   * @todo support attribute non_revoked fields
+   */
   public async createProof({
     proofRequest,
     requestedCredentials,
     schemas,
     credentialDefinitions,
-    revocationStates = {},
-  }: CreateProofOptions) {
+  }: CreateProofOptions): Promise<Indy.IndyProof> {
     try {
-      return await this.indy.proverCreateProof(
+      this.logger.debug('Creating Indy Proof')
+      const revocationStates: Indy.RevStates = await this.indyRevocationService.createRevocationState(
+        proofRequest,
+        requestedCredentials
+      )
+
+      const indyProof: Indy.IndyProof = await this.indy.proverCreateProof(
         this.wallet.handle,
         proofRequest,
-        requestedCredentials,
+        requestedCredentials.toJSON(),
         this.wallet.masterSecretId,
         schemas,
         credentialDefinitions,
         revocationStates
       )
+
+      this.logger.trace('Created Indy Proof', {
+        indyProof,
+      })
+
+      return indyProof
     } catch (error) {
-      throw new IndySdkError(error)
+      this.logger.error(`Error creating Indy Proof`, {
+        error,
+        proofRequest,
+        requestedCredentials,
+      })
+
+      throw isIndyError(error) ? new IndySdkError(error) : error
     }
   }
 
@@ -49,7 +86,7 @@ export class IndyHolderService {
     credential,
     credentialDefinition,
     credentialId,
-    revocationRegistryDefinitions,
+    revocationRegistryDefinition,
   }: StoreCredentialOptions): Promise<Indy.CredentialId> {
     try {
       return await this.indy.proverStoreCredential(
@@ -58,10 +95,14 @@ export class IndyHolderService {
         credentialRequestMetadata,
         credential,
         credentialDefinition,
-        revocationRegistryDefinitions ?? null
+        revocationRegistryDefinition ?? null
       )
     } catch (error) {
-      throw new IndySdkError(error)
+      this.logger.error(`Error storing Indy Credential '${credentialId}'`, {
+        error,
+      })
+
+      throw isIndyError(error) ? new IndySdkError(error) : error
     }
   }
 
@@ -78,7 +119,11 @@ export class IndyHolderService {
     try {
       return await this.indy.proverGetCredential(this.wallet.handle, credentialId)
     } catch (error) {
-      throw new IndySdkError(error)
+      this.logger.error(`Error getting Indy Credential '${credentialId}'`, {
+        error,
+      })
+
+      throw isIndyError(error) ? new IndySdkError(error) : error
     }
   }
 
@@ -101,7 +146,12 @@ export class IndyHolderService {
         this.wallet.masterSecretId
       )
     } catch (error) {
-      throw new IndySdkError(error)
+      this.logger.error(`Error creating Indy Credential Request`, {
+        error,
+        credentialOffer,
+      })
+
+      throw isIndyError(error) ? new IndySdkError(error) : error
     }
   }
 
@@ -177,7 +227,11 @@ export class IndyHolderService {
 
       return credentials
     } catch (error) {
-      throw new IndySdkError(error)
+      this.logger.error(`Error Fetching Indy Credentials For Referent`, {
+        error,
+      })
+
+      throw isIndyError(error) ? new IndySdkError(error) : error
     }
   }
 }
@@ -201,13 +255,12 @@ export interface StoreCredentialOptions {
   credential: Indy.Cred
   credentialDefinition: Indy.CredDef
   credentialId?: Indy.CredentialId
-  revocationRegistryDefinitions?: Indy.RevRegsDefs
+  revocationRegistryDefinition?: Indy.RevocRegDef
 }
 
 export interface CreateProofOptions {
   proofRequest: Indy.IndyProofRequest
-  requestedCredentials: Indy.IndyRequestedCredentials
+  requestedCredentials: RequestedCredentials
   schemas: Indy.Schemas
   credentialDefinitions: Indy.CredentialDefs
-  revocationStates?: Indy.RevStates
 }
diff --git a/packages/core/src/modules/indy/services/IndyIssuerService.ts b/packages/core/src/modules/indy/services/IndyIssuerService.ts
@@ -9,7 +9,6 @@ import type {
   CredReq,
   CredRevocId,
   CredValues,
-  BlobReaderHandle,
 } from 'indy-sdk'
 
 import { Lifecycle, scoped } from 'tsyringe'
@@ -18,18 +17,21 @@ import { AgentConfig } from '../../../agent/AgentConfig'
 import { AriesFrameworkError } from '../../../error/AriesFrameworkError'
 import { IndySdkError } from '../../../error/IndySdkError'
 import { isIndyError } from '../../../utils/indyError'
-import { getDirFromFilePath } from '../../../utils/path'
 import { IndyWallet } from '../../../wallet/IndyWallet'
 
+import { IndyUtilitiesService } from './IndyUtilitiesService'
+
 @scoped(Lifecycle.ContainerScoped)
 export class IndyIssuerService {
   private indy: typeof Indy
   private wallet: IndyWallet
+  private indyUtilitiesService: IndyUtilitiesService
   private fileSystem: FileSystem
 
-  public constructor(agentConfig: AgentConfig, wallet: IndyWallet) {
+  public constructor(agentConfig: AgentConfig, wallet: IndyWallet, indyUtilitiesService: IndyUtilitiesService) {
     this.indy = agentConfig.agentDependencies.indy
     this.wallet = wallet
+    this.indyUtilitiesService = indyUtilitiesService
     this.fileSystem = agentConfig.fileSystem
   }
 
@@ -44,7 +46,7 @@ export class IndyIssuerService {
 
       return schema
     } catch (error) {
-      throw new IndySdkError(error)
+      throw isIndyError(error) ? new IndySdkError(error) : error
     }
   }
 
@@ -74,7 +76,7 @@ export class IndyIssuerService {
 
       return credentialDefinition
     } catch (error) {
-      throw new IndySdkError(error)
+      throw isIndyError(error) ? new IndySdkError(error) : error
     }
   }
 
@@ -88,7 +90,7 @@ export class IndyIssuerService {
     try {
       return await this.indy.issuerCreateCredentialOffer(this.wallet.handle, credentialDefinitionId)
     } catch (error) {
-      throw new IndySdkError(error)
+      throw isIndyError(error) ? new IndySdkError(error) : error
     }
   }
 
@@ -106,7 +108,7 @@ export class IndyIssuerService {
   }: CreateCredentialOptions): Promise<[Cred, CredRevocId]> {
     try {
       // Indy SDK requires tailsReaderHandle. Use null if no tailsFilePath is present
-      const tailsReaderHandle = tailsFilePath ? await this.createTailsReader(tailsFilePath) : 0
+      const tailsReaderHandle = tailsFilePath ? await this.indyUtilitiesService.createTailsReader(tailsFilePath) : 0
 
       if (revocationRegistryId || tailsFilePath) {
         throw new AriesFrameworkError('Revocation not supported yet')
@@ -123,42 +125,7 @@ export class IndyIssuerService {
 
       return [credential, credentialRevocationId]
     } catch (error) {
-      if (isIndyError(error)) {
-        throw new IndySdkError(error)
-      }
-
-      throw error
-    }
-  }
-
-  /**
-   * Get a handler for the blob storage tails file reader.
-   *
-   * @param tailsFilePath The path of the tails file
-   * @returns The blob storage reader handle
-   */
-  private async createTailsReader(tailsFilePath: string): Promise<BlobReaderHandle> {
-    try {
-      const tailsFileExists = await this.fileSystem.exists(tailsFilePath)
-
-      // Extract directory from path (should also work with windows paths)
-      const dirname = getDirFromFilePath(tailsFilePath)
-
-      if (!tailsFileExists) {
-        throw new AriesFrameworkError(`Tails file does not exist at path ${tailsFilePath}`)
-      }
-
-      const tailsReaderConfig = {
-        base_dir: dirname,
-      }
-
-      return await this.indy.openBlobStorageReader('default', tailsReaderConfig)
-    } catch (error) {
-      if (isIndyError(error)) {
-        throw new IndySdkError(error)
-      }
-
-      throw error
+      throw isIndyError(error) ? new IndySdkError(error) : error
     }
   }
 }