Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credential received state transition #97

Merged
merged 6 commits into from
Jul 24, 2019

Conversation

nrempel
Copy link
Contributor

@nrempel nrempel commented Jul 23, 2019

This pull request adds an additional state transition for the credential exchange protocol.

When a holder receives a credential, instead of storing it immediately, the protocol enters a "received" state. The controller can then operate on the credential if it wants before storing it.

When the controller is ready for the credential to be stored in the wallet, it calls /credential_exchange/{id}/store which will carry it along to the next and (currently) state. This state is the same as it was previously.

The agent can be started with the flag --auto-store-credential to automate this step. With this flag passed, the agent behaviour is the same as before.

closes #95

@nrempel nrempel requested review from ianco and andrewwhitehead July 23, 2019 22:57
@codecov-io
Copy link

Codecov Report

Merging #97 into master will decrease coverage by 0.01%.
The diff coverage is 62.16%.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   72.74%   72.73%   -0.02%     
==========================================
  Files         178      178              
  Lines        7471     7503      +32     
==========================================
+ Hits         5435     5457      +22     
- Misses       2036     2046      +10

@nrempel nrempel merged commit 4eff9f4 into openwallet-foundation:master Jul 24, 2019
@nrempel nrempel deleted the add-cred-ex-transitions branch July 24, 2019 16:22
cjhowland pushed a commit to cjhowland/aries-cloudagent-python that referenced this pull request Sep 28, 2022
…/credential-attachments-testing

feat: testing for credential attachments additions + further coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new credential_exchange state transition credential_received
3 participants