Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outbound msg limit #725

Closed
wants to merge 4 commits into from

Conversation

krgko
Copy link

@krgko krgko commented Sep 28, 2020

Currently, The ACA-py allows for setting --max-message-size for inbound transport only. I think someone who uses the webhook feature might need to apply that config for the outbound transport max message limit also due to large messages will lead to OutboundTransportError('Unexpected response status 413, caused by: Request Entity Too Large')

This PR might be useful for some use cases which use the webhook feature and large messages.

@codecov-commenter
Copy link

Codecov Report

Merging #725 into master will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
- Coverage   99.01%   99.01%   -0.01%     
==========================================
  Files         254      254              
  Lines       13763    13768       +5     
==========================================
+ Hits        13628    13632       +4     
- Misses        135      136       +1     

@krgko krgko closed this Sep 28, 2020
@krgko krgko reopened this Sep 28, 2020
@andrewwhitehead
Copy link
Contributor

I can't be sure if this is actually fixing an issue or if it's just putting a maximum size on the outbound requests. It seems like the 413 error is being sent by the receiving agent because the payload is too large for it, not because there's a limit on the outbound payload size.

@krgko
Copy link
Author

krgko commented Oct 9, 2020

Hello @andrewwhitehead , I've rechecked the AioHTTP document and found that max_client_size can config for inbound transportation. Thus, this PR will not help because the outbound max request size relies on the allowed inbound request size for destination service.

Thank you for your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants