Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubleshoot tails file rollover #717

Conversation

sklump
Copy link
Contributor

@sklump sklump commented Sep 11, 2020

Put tails file up from admin API.
Simplify issuer revocation registry state machine and related issue-credential logic.

@sklump
Copy link
Contributor Author

sklump commented Sep 11, 2020

Please wait for Emiliano's say-so before merging. Unless he finds something I haven't, it's good to merge.

@sklump sklump marked this pull request as draft September 11, 2020 18:10
@codecov-commenter
Copy link

Codecov Report

Merging #717 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #717   +/-   ##
=======================================
  Coverage   99.00%   99.01%           
=======================================
  Files         254      254           
  Lines       13699    13763   +64     
=======================================
+ Hits        13563    13627   +64     
  Misses        136      136           

@esune
Copy link
Member

esune commented Sep 11, 2020

I think we got it! Tested as follows:

  1. create new test schema
  2. create new cred_def based on new schema, supporting revocation
    • simulated outage on tails-server during creation so that tails files could not get uploaded
  3. the agent created two revocation registries (that would not have a tails file on the server): marked both of them full
  4. issue credentials until the first registry is full, revoke all of them
  5. continue issuing credentials on the next registry, and revoke them

Everything seemed to work as expected so hopefully we're good. There is a chance of additional outages happening right when one of the "next" tails-files is being uploaded to the tails-server, but haven't pushed my luck that far with testing since it really looks like an even rarer edge case considering now we have multiple retries to upload.

@sklump sklump marked this pull request as ready for review September 12, 2020 01:48
esune
esune previously approved these changes Sep 14, 2020
@sklump sklump requested review from andrewwhitehead and removed request for andrewwhitehead September 15, 2020 10:33
Signed-off-by: sklump <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants