Check for fatal ledger errors on dispatch task completion #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #659 +/- ##
==========================================
- Coverage 98.70% 98.68% -0.02%
==========================================
Files 250 250
Lines 13389 13393 +4
==========================================
+ Hits 13215 13217 +2
- Misses 174 176 +2 |
Signed-off-by: Ian Costanzo <[email protected]>
sklump
previously approved these changes
Aug 11, 2020
sklump
reviewed
Aug 11, 2020
| if isinstance(completed.exc_info[1], LedgerConfigError) or isinstance( | ||
| completed.exc_info[1], LedgerTransactionError | ||
| ): | ||
| LOGGER.error("Shutdown with %s", str(completed.exc_info[1])) |
There was a problem hiding this comment.
Could cover with unit test in test_conductor.py:
async def test_dispatch_complete_fatal_x(self):
builder: ContextBuilder = StubContextBuilder(self.test_settings)
conductor = test_module.Conductor(builder)
message_body = "{}"
receipt = MessageReceipt(direct_response_mode="snail mail")
message = InboundMessage(message_body, receipt)
mock_task = async_mock.MagicMock(
exc_info=(test_module.LedgerTransactionError, ("Ledger is wobbly"), "..."),
ident="abc",
timing={
"queued": 1234567890,
"unqueued": 1234567899,
"started": 1234567901,
"ended": 1234567999,
},
)
await conductor.setup()
conductor.dispatch_complete(message, mock_task)
There was a problem hiding this comment.
Test added, thanks @sklump !
Signed-off-by: Ian Costanzo <[email protected]>
|
This looks great, thanks |
sklump
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Costanzo [email protected]