Correct revocation API in credential revocation documentation #612
Conversation
Signed-off-by: Ethan Sung <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
=======================================
Coverage 96.60% 96.60%
=======================================
Files 248 248
Lines 13206 13206
=======================================
Hits 12758 12758
Misses 448 448 |
| ``` | ||
| POST /issue-credential/records/{cred_ex_id}/revoke | ||
| POST /issue-credential/revoke |
There was a problem hiding this comment.
Could we add an example body data for this POST request? I think this POST will need query params as
issue-credential/revoke?rev_reg_id=<revocation_registry_id>&cred_rev_id=<credential_definition_id>&publish=<true|false>
There was a problem hiding this comment.
@swcurran
Please Check, the URL once, could not revoke credential in that URL. Image attaches along with it. Thanks!!
|
@nrempel is in the midst of revising the revocation API to make it a lot easier for the controller and controller developer. He's almost finished the changes. I'm going to leave this PR for him to decide on approving or closing because of his changes. Thanks @baegjae - and sorry if you are caught in the middle of this upgrade. |
|
Thanks for this! This portion of the API isn't changing so this is good. I agree with @anhem115's comments. If you could make a slight adjustment to include their recommendation, I'll merge this. Thanks! |
Signed-off-by: Ethan Sung <[email protected]>
|
Thanks for the PR! |
…ocation-document Correct revocation API in credential revocation documentation Signed-off-by: Nicholas Rempel <[email protected]>
I found that changes of the revocation API (#428) have not yet been applied to the credential revocation documentation.
Changed to the correct revocation API.
Signed-off-by: Ethan Sung [email protected]