Allow access to swagger UI when protected by API key #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
+ Coverage 96.77% 96.79% +0.02%
==========================================
Files 240 240
Lines 12786 12805 +19
==========================================
+ Hits 12374 12395 +21
+ Misses 412 410 -2 |
andrewwhitehead
force-pushed
the
feature/unprotected-swagger
branch
from
248298a to
82c00bd
Compare
Signed-off-by: Andrew Whitehead <[email protected]>
This is the proposed option number 2. It uses the websocket to expect a message with the admin api key before it is being used to transmit any other messages than 'ping' Signed-off-by: Matthias Binzer <[email protected]>
andrewwhitehead
force-pushed
the
feature/unprotected-swagger
branch
from
82c00bd to
26410d0
Compare
sklump
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And show authorization options in swagger UI
Includes changes from PR #528