Error audit protocols #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sklump <[email protected]>
Signed-off-by: sklump <[email protected]>
Signed-off-by: sklump <[email protected]>
…ent-python into error-audit-protocols
Signed-off-by: sklump <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
==========================================
+ Coverage 96.39% 96.42% +0.02%
==========================================
Files 240 240
Lines 12575 12657 +82
==========================================
+ Hits 12122 12204 +82
Misses 453 453 |
| @@ -40,6 +40,7 @@ async def sign(request: web.BaseRequest): | |||
| try: | |||
| context = request.app["request_context"] | |||
| wallet: BaseWallet = await context.inject(BaseWallet) | |||
| wallet: BaseWallet = await context.inject(BaseWallet) | |||
There was a problem hiding this comment.
Good catch: I will fix it
| my_label = request.query.get("my_label") or None | ||
| my_endpoint = request.query.get("my_endpoint") or None | ||
| request = await connection_mgr.create_request(connection, my_label, my_endpoint) | ||
| except (StorageError, WalletError, ConnectionManagerError, BaseModelError) as err: |
There was a problem hiding this comment.
Should it just catch BaseError?
There was a problem hiding this comment.
I think it's OK to be specific here: catching an omnibus error will probably make LGTM-bot squawk.
There was a problem hiding this comment.
I'd prefer to see what can happen in particular.
Signed-off-by: sklump <[email protected]>
andrewwhitehead
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.