Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch common exceptions in routes and raise web errors instead of 500… #539

Merged

Conversation

sklump
Copy link
Contributor

@sklump sklump commented Jun 2, 2020

…: server got itself in trouble

Still to do: this exercise in much of protocols/**. In time.

Signed-off-by: sklump [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #539 into master will increase coverage by 0.00%.
The diff coverage is 99.51%.

@@           Coverage Diff           @@
##           master     #539   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files         237      237           
  Lines       12388    12434   +46     
=======================================
+ Hits        11955    12000   +45     
- Misses        433      434    +1     

@lgtm-com
Copy link

lgtm-com bot commented Jun 2, 2020

This pull request introduces 1 alert when merging 76a06f8 into d95c9de - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

Copy link
Contributor

@andrewwhitehead andrewwhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very thorough

@andrewwhitehead andrewwhitehead merged commit 70d540a into openwallet-foundation:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants