Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo tails server #499

Merged
merged 8 commits into from
May 13, 2020
Merged

Conversation

nrempel
Copy link
Contributor

@nrempel nrempel commented May 8, 2020

This PR updates the phone demo to use the new tails server available here: https://github.com/bcgov/von-tails-server

Nicholas Rempel added 3 commits April 30, 2020 15:44
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
@nrempel nrempel requested a review from swcurran May 8, 2020 22:25
Signed-off-by: Nicholas Rempel <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented May 8, 2020

This pull request introduces 2 alerts when merging 7149abf into e81a2b8 - view on LGTM.com

new alerts:

  • 2 for Unused import

@swcurran
Copy link
Contributor

Some things to do, I think.

  1. Please rename von-tails-server to indy-tails-server. That's a more appropriate name for this component.
  2. On the free account, I was not able to run two ngroks. Is it possible to start up two in one session? I think @esune is doing that with identity-kit, but I could be wrong.
  3. The same Emiliano chap was able to start ngrok in the background and automatically determine the appropriate URLs created by nrgok. It would be really nice to use that same technique here to do that.

I'm stuck on 2 and can't proceed without getting a higher level ngrok account. I'm fine with that but it won't work very well for a public demo of this. Any other ideas?

@lgtm-com
Copy link

lgtm-com bot commented May 11, 2020

This pull request introduces 2 alerts when merging c214642 into e81a2b8 - view on LGTM.com

new alerts:

  • 2 for Unused import

@sklump
Copy link
Contributor

sklump commented May 11, 2020

Please remove unused imports so my phone doesn't go off on push?

@esune
Copy link
Member

esune commented May 11, 2020

Some things to do, I think.

1. Please rename von-tails-server to indy-tails-server.  That's a more appropriate name for this component.

2. On the free account, I was not able to run two ngroks.  Is it possible to start up two in one session?  I think @esune is doing that with identity-kit, but I could be wrong.

3. The same Emiliano chap was able to start ngrok in the background and automatically determine the appropriate URLs created by nrgok.  It would be really nice to use that same technique here to do that.

I'm stuck on 2 and can't proceed without getting a higher level ngrok account. I'm fine with that but it won't work very well for a public demo of this. Any other ideas?

I think the free ngrok account limits you to two tunnels unfortunately. One way around this (not sure) could be to use the dockerized version of ngrok like the one used in aries-toolbox, but haven't tried yet so it needs to be confirmed.

Nicholas Rempel added 2 commits May 11, 2020 11:31
@nrempel
Copy link
Contributor Author

nrempel commented May 11, 2020

I've tested opening 6 concurrent ngrok tunnels without issue. Version 2.3.35. What version do you have installed?

@esune
Copy link
Member

esune commented May 11, 2020

Same version. How are you starting ngrok? If you are starting one tunnel at a time it may be possible to have more than two, this is what I get when I try to start more than two tunnels at the same time using a configuration file:

ngrok.io https://d24b48ef.ngrok.io]\n\r\n\r\nERR_NGROK_324\r\n"
Your account may not run more than 2 tunnels over a single ngrok client session.
The tunnels already running on this session are:
[https://968e7ecf.ngrok.io https://d24b48ef.ngrok.io]

@nrempel
Copy link
Contributor Author

nrempel commented May 11, 2020

I've confirmed with Stephen that this limitation only exists if you are logged in and not paying for an account. If you are not logged-in, there is no limit.

@esune
Copy link
Member

esune commented May 11, 2020

I've confirmed with Stephen that this limitation only exists if you are logged in and not paying for an account. If you are not logged-in, there is no limit.

How do you check whether you are logged-in or not? I have never logged-in to ngrok (I do not have an account) and still get the error...

@swcurran
Copy link
Contributor

I was able to get this to work after a little playing around.

  • getting the ngrok unlinked from my account (by remove ~/.ngrok folder) got me passed the ngrok account limitation.
  • Switching from a light theme to a dark on my terminal (vscode, in my case) solved the QR code being unusable.

After that, I could get the demo to work with Streetcred and eSatus quite happily.

Nick - anything we can do with the QR code generator to generate in the correct colours always? Ideally an autodetect.

It would be great if we could do what Emiliano did to auto-parse the ngrok URLs and invoke them automatically. Getting them copied and pasted was a bit of a pain. Manageable, but what Emiliano did was way slicker :-).

@esune
Copy link
Member

esune commented May 11, 2020

Using a configuration file like this one the tunnels can be named.

Then a script like this one can be used to pull the endpoint out of the running ngrok instance (using jq, that needs to be installed).

@esune
Copy link
Member

esune commented May 11, 2020

I was able to get this to work after a little playing around.

* getting the ngrok unlinked from my account (by remove ~/.ngrok folder) got me passed the ngrok account limitation.

FYI I do NOT have an ngrok account (or a .ngrok folder in my home) and I still can't start more than two tunnels.

@swcurran
Copy link
Contributor

For this a user only needs two tunnels.  My issue was that I couldn't create more than 1.

@esune
Copy link
Member

esune commented May 11, 2020

For this a user only needs two tunnels. My issue was that I couldn't create more than 1.

Oh, I see. I was still going with Nick's ability of creating more than two tunnels. If this is the case I guess we're good.

@ianco ianco merged commit de29118 into openwallet-foundation:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants