Demo updates 2 #449
Merged
Demo updates 2 #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
swcurran
reviewed
Apr 4, 2020
swcurran
reviewed
Apr 4, 2020
demo/runners/support/agent.py
Outdated
| log_msg(f"External host Tails File URL: {tails_file_external_url}") | ||
| log_msg(f"================") | ||
| log_msg(f"mkdir -p ./revocation/registry/{revocation_registry_id}/") | ||
| log_msg(f"curl -X GET \"{tails_file_external_url}\" --output /tmp/tails-files/revocation/registry/{revocation_registry_id}/tails-file.txt") |
There was a problem hiding this comment.
On the output file, there is still the "/tmp/tails-files". Please remove.
swcurran
reviewed
Apr 4, 2020
swcurran
reviewed
Apr 4, 2020
demo/runners/support/agent.py
Outdated
| @@ -219,21 +219,28 @@ def __init__( | |||
| # Update the revocation registry with the public URL to the tails file | |||
| tails_file_admin_url = f"{self.admin_url}/revocation/registry/{revocation_registry_id}/tails-file" | |||
| tails_file_url = f"{self.public_tails_url}/revocation/registry/{revocation_registry_id}/tails-file" | |||
| tails_file_external_url = f"{self.endpoint}/revocation/registry/{revocation_registry_id}/tails-file" | |||
There was a problem hiding this comment.
Looks like "self.endpoint" should be something else to get port 8021
swcurran
requested changes
Apr 5, 2020
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
==========================================
- Coverage 89.47% 89.05% -0.42%
==========================================
Files 248 248
Lines 12213 12205 -8
==========================================
- Hits 10927 10869 -58
- Misses 1286 1336 +50 |
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
swcurran
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new demo parameter --self-attested (the default it to NOT include self attested attributes in the proof request)
Updated the tails file commands to include the proper host name when on PWD (so you can just copy and paste the commands directly)
Included the "base64" command as a temporary workaround for eSatus wallet