Update the run_demo script to add background mode and usage info #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Curran <[email protected]>
demo/run_demo
Outdated
| @@ -46,6 +50,38 @@ do | |||
| echo "For example, to create the directory and then set the permissions use: 'mkdir ../logs; chmod uga+rws ../logs'" | |||
| exit 1 | |||
| fi | |||
| continue | |||
There was a problem hiding this comment.
Adding continue here means that the argument gets stripped off, which I don't think is intended.
There was a problem hiding this comment.
Thanks - wasn't sure about that.
There was a problem hiding this comment.
Confirmed that --timing works.
demo/run_demo
Outdated
| --bg) | ||
| if [[ "${AGENT}" == "alice" ]] || [[ "${AGENT}" == "faber" ]] || [[ "${AGENT}" == "acme" ]]; then | ||
| DOCKER_OPTS="-d" | ||
| echo -e "\nRunning in ${AGENT} in the background. Note that you cannot use the comand line console in this mode." |
Signed-off-by: Stephen Curran <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
======================================
Coverage 88.1% 88.1%
======================================
Files 245 245
Lines 11993 11993
======================================
Hits 10566 10566
Misses 1427 1427 |
andrewwhitehead
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.