Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow faber to continue when connection is in 'response' state #422

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Mar 16, 2020

Signed-off-by: Ian Costanzo [email protected]

Makes the mobile demo a bit cleaner, as the connection will only be in "response" state when accepted by the mobile agent.

Tested and we can send a credential when the connection state is "response".

@ianco ianco requested a review from swcurran March 16, 2020 16:45
@sukalpomitra
Copy link

@ianco @swcurran @andrewwhitehead I observed with hyperledger version of the code I can see the OSMA in connected state. But if i use ianco's repo, i can see the faber console but OSMA connection is always at negotiating. state

@swcurran swcurran added the blocked This PR is blocked pending coordination label Mar 16, 2020
@sukalpomitra
Copy link

@ianco @swcurran - This was an issue on my side, where I mistakenly was using an old consumer id of the mediator. I can see OSMA moving to connected and faber console also coming

Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@swcurran swcurran merged commit 5e4d783 into openwallet-foundation:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This PR is blocked pending coordination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants