Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept self attested attributes in pre-verify; add logging #394

Merged

Conversation

andrewwhitehead
Copy link
Contributor

Fixes #393

@andrewwhitehead andrewwhitehead requested a review from swcurran March 1, 2020 20:59
@codecov-io
Copy link

Codecov Report

Merging #394 into master will decrease coverage by 0.08%.
The diff coverage is 53.84%.

@@            Coverage Diff            @@
##           master    #394      +/-   ##
=========================================
- Coverage   89.09%     89%   -0.09%     
=========================================
  Files         236     236              
  Lines       11297   11319      +22     
=========================================
+ Hits        10065   10075      +10     
- Misses       1232    1244      +12

@swcurran
Copy link
Contributor

swcurran commented Mar 1, 2020

Looks good, but need to get to internet to test. Thanks. We'll need another release for this, eh?

Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, demo runs again.

@swcurran swcurran merged commit 7cb5de8 into openwallet-foundation:master Mar 2, 2020
@andrewwhitehead andrewwhitehead deleted the fix/pre-verify branch February 25, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running straight Alice/Faber demo gives "Proof=false" result
3 participants