Fix pre-verify check #390
Merged
Fix pre-verify check #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <[email protected]>
andrewwhitehead
approved these changes
Feb 28, 2020
|
@dbluhm - how did that manifest? We're trying to decide if we need an immediate release because of this. Thanks! |
|
Working through our toolbox demos and I tried a presentation with only a predicate on an age attribute. It showed up as this error: |
|
Sorry to hear about that. We need to figure out how to prevent that in the future. We want to have trust in the updates we release. Something for us to ponder. |
|
No worries; thanks for responding quickly and getting a release out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be a typo that is causing
pre_verifyto returnNonewhen it should be returningOK