Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated AriesOpenAPIDemo.md #382

Merged
merged 1 commit into from
Feb 23, 2020
Merged

Updated AriesOpenAPIDemo.md #382

merged 1 commit into from
Feb 23, 2020

Conversation

shaktishenoy
Copy link
Contributor

Added screenshots from @sklump
Signed-off-by: shaktishenoy [email protected]

@shaktishenoy shaktishenoy requested a review from sklump February 22, 2020 18:46
@codecov-io
Copy link

Codecov Report

Merging #382 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   89.12%   89.12%           
=======================================
  Files         236      236           
  Lines       11279    11279           
=======================================
  Hits        10052    10052           
  Misses       1227     1227

@swcurran
Copy link
Contributor

This is cool! Thanks. Will go through this shortly.

I don't know if you would be interested in doing this, but I'd like to get this OpenAPI demo so that instead of using the /send endpoint for issuing, it uses the full offer/request/response protocol. That would give a new person using this more of a feel of what a controller needs to do.

We'll be updating it shortly to use the --events and --no-auto parameters so that the developer learns about what the webhook messages look like and how data can be pulled from those to populate the requests sent to the endpoints.

@shaktishenoy
Copy link
Contributor Author

This is cool! Thanks. Will go through this shortly.

I don't know if you would be interested in doing this, but I'd like to get this OpenAPI demo so that instead of using the /send endpoint for issuing, it uses the full offer/request/response protocol. That would give a new person using this more of a feel of what a controller needs to do.

We'll be updating it shortly to use the --events and --no-auto parameters so that the developer learns about what the webhook messages look like and how data can be pulled from those to populate the requests sent to the endpoints.

Sure! Let me know when the changes are done.

Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@swcurran swcurran merged commit 2435db9 into openwallet-foundation:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants