Pg scheme support #378
Merged
Pg scheme support #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
| if raise_exc: | ||
| raise OSError(f"Error unable to configure postgres stg: {result}") | ||
| else: | ||
| raise SystemExit(1) |
There was a problem hiding this comment.
This code is only run once, the first time a PG wallet is opened. Does it need to run more than once if there's different storage types?
There was a problem hiding this comment.
There should only be one storage type per postgres instance, so the code should only be run once.
andrewwhitehead
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for additional postgres wallet schemes, such as "MultiWalletDatabase"