Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to run_docker script for windows bash compatibility #357

Merged
merged 3 commits into from
Feb 6, 2020

Conversation

esune
Copy link
Member

@esune esune commented Jan 31, 2020

Fixes compatibility issues with the run_docker script when running in bash under windows.

Tested with:

  • GNU bash, version 4.4.23(1)-release (x86_64-pc-msys)
  • GNU bash, version 4.4.20(1)-release (x86_64-pc-linux-gnu) (WSL in Windows 10)

@esune esune requested a review from WadeBarnes January 31, 2020 23:31
@codecov-io
Copy link

Codecov Report

Merging #357 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #357   +/-   ##
=======================================
  Coverage   89.24%   89.24%           
=======================================
  Files         236      236           
  Lines       11187    11187           
=======================================
  Hits         9984     9984           
  Misses       1203     1203

@esune esune requested a review from andrewwhitehead January 31, 2020 23:44
@andrewwhitehead
Copy link
Contributor

Please update demo/run_demo as well

@esune
Copy link
Member Author

esune commented Feb 3, 2020

@andrewwhitehead done! Sorry I missed that.

I also added run_demo to .gitattributes as the line endings were being switched to crlf in Windows (everything in the scripts folder is already handled correctly).

@andrewwhitehead andrewwhitehead merged commit 500b678 into openwallet-foundation:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants