Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accommodate proofs with repeat cred defs, check for bait-and-switch b… #330

Merged

Conversation

sklump
Copy link
Contributor

@sklump sklump commented Jan 17, 2020

…etween presentation proposal and request

Signed-off-by: sklump [email protected]

…etween presentation proposal and request

Signed-off-by: sklump <[email protected]>
@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #330 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   89.04%   89.07%   +0.02%     
==========================================
  Files         236      237       +1     
  Lines       11084    11113      +29     
==========================================
+ Hits         9870     9899      +29     
  Misses       1214     1214

@swcurran
Copy link
Contributor

We definitely need to be able to support that use case. @sklump - if something needs to be added to or clarified in the aries-RFC 0037, please let me know.

@sklump
Copy link
Contributor Author

sklump commented Jan 17, 2020

Sorry, I figured it was redundant with send...(). I will put it back and amend the PR Monday.

Copy link
Contributor

@andrewwhitehead andrewwhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewwhitehead andrewwhitehead merged commit bb86a63 into openwallet-foundation:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants