-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data integrity routes #3261
Data integrity routes #3261
Conversation
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
…dagent-python into data-integrity-routes
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick pass, I'll have to come back for more review.
aries_cloudagent/vc/data_integrity/cryptosuites/eddsa_jcs_2022.py
Outdated
Show resolved
Hide resolved
aries_cloudagent/vc/data_integrity/cryptosuites/eddsa_jcs_2022.py
Outdated
Show resolved
Hide resolved
aries_cloudagent/vc/data_integrity/cryptosuites/eddsa_jcs_2022.py
Outdated
Show resolved
Hide resolved
aries_cloudagent/vc/data_integrity/cryptosuites/eddsa_jcs_2022.py
Outdated
Show resolved
Hide resolved
aries_cloudagent/vc/data_integrity/cryptosuites/eddsa_jcs_2022.py
Outdated
Show resolved
Hide resolved
aries_cloudagent/vc/data_integrity/cryptosuites/eddsa_jcs_2022.py
Outdated
Show resolved
Hide resolved
aries_cloudagent/vc/data_integrity/cryptosuites/eddsa_jcs_2022.py
Outdated
Show resolved
Hide resolved
aries_cloudagent/vc/data_integrity/cryptosuites/eddsa_jcs_2022.py
Outdated
Show resolved
Hide resolved
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
…st files Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
I just ran the test locally and I don't get a single failure. |
The error I'm getting is
Can someone shed some light as in how my PR is affecting the |
I'm not working today and can have a closer look tomorrow. For the unit tests it looks like there's an error. I'm not sure why it wouldn't happen locally. But there's also a warning and the the github action fails on most warnings. There's something going on here. For the interop integration tests the AATH just upgraded promp_toolkit and it's conflicting with the version in acapy :/ openwallet-foundation/owl-agent-test-harness#873. Apparently both projects use it. We'll either have to upgradeit in aca-py or revert it in AATH for this workflow to work. |
Signed-off-by: PatStLouis <[email protected]>
I noticed you did a general update to the poetry.lock file. Probably using |
@jamshale thanks for the pointer, I bumped the prompt-toolkit version to match the version required by AATH ( |
…peration Signed-off-by: PatStLouis <[email protected]>
I copied the lock file from main and applied a |
@jamshale using |
Commented on the aath PR about the prompt toolkit version: |
Ya. I think I looked at prompt-toolkit a while ago and decided to stay on major version 2. I think reverting it in AATH would be the best. I'll talk to Stephen about it tomorrow. |
@dbluhm all tests are now passing except the BDD which are currently broken due to a version upgrade of a package in aath. If I could have a final review before merging this would be appreciated. |
There's a few minor issues reported by sonarcloud. I think most of them can be ignored but the redundant exception class could easily be fixed. https://sonarcloud.io/project/issues?id=hyperledger_aries-cloudagent-python&pullRequest=3261&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true |
Signed-off-by: PatStLouis <[email protected]>
aries_cloudagent/vc/data_integrity/cryptosuites/eddsa_jcs_2022.py
Outdated
Show resolved
Hide resolved
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
@jamshale I applied a couple of the fixes suggested by sonarcloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working through my comments. I think these changes look good 👍
Agreed and I think the responses from the api calls are a lot more intuitive. |
Quality Gate passedIssues Measures |
@PatStLouis Are you able to merge this yourself now? |
This supersedes #3181 with a better architecture based on the MultikeyManager class.
@jamshale @dbluhm this is mostly the same code as the other pr so review should be light.
I would like to get this in the up comming release if possible.
Adds support for
Here's the tracelog of reviews from the previous PR:
@dbluhm said:
The reason I had separated them is because the wallet routes was a very bloated file. In this PR I went with the plugin model for data integrity which is a lot more manageable. The schemas are now closer to the request handlers.
@dbluhm said:
This has been addressed by removing linked data support for the time being, therefore this URI is no longer needed for validation. We will review / re haul LD support when implementing eddsa-edfc-2022, it's due for improvement.
Other notable improvements:
The crypto suite has now been split into functions, each reflecting a specific algorithm form the spec (can almost be followed line by line). Links are in the doc string.
It now lives at the
/vc/di/*
endpoints, since this is the vc-data-integrity specification.Future improvements: