Removing padding from url invitations #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jamie Hale <[email protected]>
Signed-off-by: Jamie Hale <[email protected]>
Signed-off-by: Jamie Hale <[email protected]>
Signed-off-by: Jamie Hale <[email protected]>
|
swcurran
approved these changes
Sep 18, 2024
ff137
pushed a commit
to ff137/acapy
that referenced
this pull request
Oct 22, 2024
* Removing padding for oob invitation url Signed-off-by: Jamie Hale <[email protected]> * Removing padding for connection invitation url Signed-off-by: Jamie Hale <[email protected]> * Fix padding test Signed-off-by: Jamie Hale <[email protected]> * Re-sync Signed-off-by: Jamie Hale <[email protected]> --------- Signed-off-by: Jamie Hale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't understand this for a while but looking at the RFC PR, I think this is all that's needed.
Uses the common util in the wallet directory to remove the padding from the url via the
bytes_to_b64function. Then this same util module is used withb64_to_byteswhich pads the invitation string when one is received. This was already in place, meaning that aca-py already handled unpadded invitation urls.This util is used in several other places, mostly for attachment and jws signing. They all remove padding as well. The only place it looks to be used with padding is for bbs_bls_signature proof values. I'm not sure if this is required or not.
NOTE: I changed it for the old connection invitation endpoint as well even though is depreciated and didn't get update in the RFC.