Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Enable linux/arm64 docker builds #3171

Merged

Conversation

rblaine95
Copy link
Contributor

  • 1.0.0rc6 resolved build issues for linux/arm64 for the normal image
  • Extended image is linux/amd64 only due to bbs
  • linux/386 still appears to have issues

@rblaine95 rblaine95 force-pushed the feature/enable-arm64-docker branch 2 times, most recently from 6c95725 to d9e5b0f Compare August 16, 2024 14:20
* `1.0.0rc6` resolved build issues for `linux/arm64`

Signed-off-by: Robbie Blaine <[email protected]>
@rblaine95 rblaine95 force-pushed the feature/enable-arm64-docker branch from d9e5b0f to 19faf49 Compare August 16, 2024 14:20
Copy link

Copy link
Contributor

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swcurran
Copy link
Contributor

Good stuff — how does this relate to the previous work done in #3127? E.g. was this additional needed to complete that?

@rblaine95
Copy link
Contributor Author

rblaine95 commented Aug 16, 2024

@swcurran, #3127 made all the necessary code changes for linux/arm64 builds to work, this PR enables the linux/arm64 platform for the Docker Builds to actually build and push the multi-arch docker images.

Current latest nightly (https://github.com/hyperledger/aries-cloudagent-python/pkgs/container/aries-cloudagent-python/254334709?tag=py3.12-nightly-2024-08-07) :
image

The test image I built earlier (https://github.com/didx-xyz/aries-cloudagent-python/actions/runs/10419734030)
image

@swcurran swcurran merged commit fd31065 into openwallet-foundation:main Aug 16, 2024
8 checks passed
@rblaine95 rblaine95 deleted the feature/enable-arm64-docker branch August 16, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants