Update TxnOrPublishRevocationsResultSchema
#3164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cl0ete <[email protected]>
Signed-off-by: cl0ete <[email protected]>
Signed-off-by: cl0ete <[email protected]>
Signed-off-by: cl0ete <[email protected]>
Signed-off-by: cl0ete <[email protected]>
Signed-off-by: cl0ete <[email protected]>
Signed-off-by: cl0ete <[email protected]>
Signed-off-by: cl0ete <[email protected]>
Signed-off-by: cl0ete <[email protected]>
Signed-off-by: cl0ete <[email protected]>
|
Tested that the OpenAPI and SwaggerAPI files match the generated. I don’t know enough about the functionality to determine if it is right — adding reviewers. For reviewers — is this OK to go into 1.0.0 or should we hold it until that is complete? |
jamshale
approved these changes
Aug 14, 2024
|
@swcurran This should be safe to include in 1.0.0. I didn't think it was important enough to need to get in, but we could include it if it doesn't hold anything up. edit: If we wanted to change it later it would have to be considered a breaking change ( Although minor ). So might as well get it in. |
|
darshilnb
pushed a commit
to Northern-Block/aries-cloudagent-python
that referenced
this pull request
Sep 5, 2024
) * fix response for publish revocations Signed-off-by: cl0ete <[email protected]> * add logging Signed-off-by: cl0ete <[email protected]> * update model to make txn a list of TransactionRecordSchema Signed-off-by: cl0ete <[email protected]> * update return value to match response model Signed-off-by: cl0ete <[email protected]> * remove logging Signed-off-by: cl0ete <[email protected]> * ran script generate-open-api-spec Signed-off-by: cl0ete <[email protected]> * remove white space Signed-off-by: cl0ete <[email protected]> * TxnOrPublishRevocations... extends PublishRevocationsSchema Signed-off-by: cl0ete <[email protected]> * remove sent i.e. revert back Signed-off-by: cl0ete <[email protected]> * ran script generate-open-api-spec Signed-off-by: cl0ete <[email protected]> --------- Signed-off-by: cl0ete <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
TxnOrPublishRevocationsResultSchemato accommodate changes made in PR #3107Tweak return values from
publish_revocationsto match response model.Ran the script
generate-open-api-specto updateopenapi.jsonandswagger.jsonfiles