Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply security patch 0.11.x #3120

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Jul 23, 2024

Apply security patch to branch 0.11.x

Integration tests currently need to be ran manually on patch releases. I ran all the @gha tag tests against a local von network and tails server and all 4 features passed.

@jamshale jamshale marked this pull request as ready for review July 23, 2024 19:26
@swcurran
Copy link
Contributor

Running AATH tests…so far so good.

@swcurran
Copy link
Contributor

Very weird. With these changes, all but a set of 7 peer-did tests fail. When I run with 0.11.x branch in ACA-Py a whole bunch more tests fail — coordinate mediation, oob, issue credential and one present proof. Running again, in case it was a glitch, but local tests are usually pretty reliable…

@jamshale
Copy link
Contributor Author

jamshale commented Jul 24, 2024

Interesting. I've only run the integration tests for acapy for this patch. The AATH acapy runset all passed for me for the 0.12.x patch.

Going to run on the current 0.11.x branch and patched forked branch and see if there's any differences.

@dbluhm
Copy link
Contributor

dbluhm commented Jul 24, 2024

Most of the peer did work wasn't merged until 0.12.0, right? We should expect AATH peer did tests to fail, wouldn't we?

@jamshale
Copy link
Contributor Author

I think that aligns with what tests failed. I kind of expected some failing tests with this branch.

@swcurran
Copy link
Contributor

Ran the AATH acapy runset with this PR, 0.11.x/3.12 and 0.11.x/3.9. All were consistent, with the same set of tests failing that would be expected — things added after 0.11.x. However, as noted above, one of the two 0.11.x/3.12 tests had some additional failures — but worked the next time.

I think we’re good with this, and we can go ahead.

Next up will be a PR to publish the patch release. Stay tuned!

@swcurran swcurran merged commit 47d6689 into openwallet-foundation:0.11.x Jul 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants